Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix meta description on news page #2545

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Fix meta description on news page #2545

merged 3 commits into from
Oct 2, 2024

Conversation

hursey013
Copy link
Contributor

Changes proposed in this pull request:

  • Uses the main site description for the news page meta description, this resolves the page url unfurling this:
    Screenshot 2024-10-01 at 11 11 47 AM

Security Considerations

None

@hursey013 hursey013 requested a review from a team as a code owner October 1, 2024 15:12
Signed-off-by: Brian Hurst <[email protected]>
@drewbo
Copy link
Contributor

drewbo commented Oct 1, 2024

@hursey013 this also happens on the knowledge base page, can you modify for that as well?

Signed-off-by: Brian Hurst <[email protected]>
@hursey013
Copy link
Contributor Author

@hursey013 this also happens on the knowledge base page, can you modify for that as well?

This is obviously a hacky solution, but added the knowledgebase url to the conditional as well.

@sknep
Copy link
Contributor

sknep commented Oct 1, 2024

@jamesthebrooks just wanna make sure you're aware of this fix since you prob already forked the site

@hursey013 hursey013 added this pull request to the merge queue Oct 2, 2024
Merged via the queue into main with commit 440c781 Oct 2, 2024
5 of 6 checks passed
@hursey013 hursey013 deleted the bh-fix-meta-news branch October 2, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants